Allow specification of buffer length for GCS to Samba #38373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: jslepicka-apex <110119914+jslepicka-apex@users.noreply.github.com>
Taragolis
reviewed
Mar 21, 2024
Co-Authored-By: jslepicka-apex <110119914+jslepicka-apex@users.noreply.github.com>
collinmcnulty
force-pushed
the
gcs-samba-buffer-len
branch
from
77f4bf4 to
654f04c
Compare
|
Nice, could you also add tests when the new parameters provided, this might help to avoid some kind regression in the future |
Taragolis
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the SambaHook and therefore the GCSToSambaOperator did not allow changing the buffer length used to copy the files to Samba. This lead to very long upload times for 10GB+ files. After increasing the buffer size, the time to upload could be reduced by an order of magnitude.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.