Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExternalPythonOperator use version from sys.version_info #38377

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

Taragolis
Copy link
Contributor

Replace parse output from python --version to parse string representation of sys.version_info


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:core-operators Operators, Sensors and hooks within Core Airflow label Mar 21, 2024
@Taragolis Taragolis added the full tests needed We need to run full set of tests for this PR to merge label Mar 21, 2024
@Taragolis
Copy link
Contributor Author

It is core operators, just in case run it as full test

@Taragolis Taragolis closed this Mar 21, 2024
@Taragolis Taragolis reopened this Mar 21, 2024
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE!

@potiuk potiuk merged commit 48c8f35 into apache:main Mar 23, 2024
122 of 132 checks passed
@Taragolis Taragolis deleted the avoid-version-from-cmd-output branch March 23, 2024 16:45
@Taragolis
Copy link
Contributor Author

NICE!

Really nice approach how it works into the virtualenv: https://github.com/pypa/virtualenv/blob/main/src/virtualenv/discovery/py_info.py 😅 but for our usage it not required

@ephraimbuddy ephraimbuddy added the type:improvement Changelog: Improvements label Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core-operators Operators, Sensors and hooks within Core Airflow full tests needed We need to run full set of tests for this PR to merge type:improvement Changelog: Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants