-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add exclude/include events filters to audit log #38506
Add exclude/include events filters to audit log #38506
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's an interesting feature.
Found a few issues while giving this a spin. "No options" - when you first enter into the filter form field, it says there are no options. Even when you start typing say "ru", "running" doesn't come up. Is it possible to hide the suggested options entirely? If you do want suggestions to work, it really needs to be a complete list of events for the DAG (which likely isn't trivial to get with the current rest api). Both included and excluded events - can we maybe disable the "excluded" events form field when the "included" events is populated? Having both on is a little funky and it feels natural for "included" to take higher precedence to me. Not really related to this change, but I noticed the count isn't using the included/excluded event filter. See #38625. |
e6bed54
to
d2fa53f
Compare
Let's resolve these findings in a follow-up PR. Merging this so that we can include in 2.9.0 |
I also agree with @jedcunningham that we should remove 'No options' and only keep |
Co-authored-by: Wei Lee <weilee.rx@gmail.com> (cherry picked from commit 32c88a2)
Co-authored-by: Wei Lee <weilee.rx@gmail.com> (cherry picked from commit 32c88a2)
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Add the ability to filter the audit logs by events to include/exclude. Send the config values to the UI to act as the default value.
Also, some fixes to the react-select option in the dataset searchbar
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.