-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide internals of some groupped workflows #38604
Merged
potiuk
merged 1 commit into
apache:main
from
potiuk:hide-internals-of-skipped-workflows
Mar 29, 2024
Merged
Hide internals of some groupped workflows #38604
potiuk
merged 1 commit into
apache:main
from
potiuk:hide-internals-of-skipped-workflows
Mar 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
requested review from
pankajkoti,
aritra24,
hussein-awala,
Taragolis,
ephraimbuddy and
eladkal
March 29, 2024 01:16
potiuk
force-pushed
the
hide-internals-of-skipped-workflows
branch
from
March 29, 2024 01:18
99a5d62
to
2ce698f
Compare
potiuk
force-pushed
the
hide-internals-of-skipped-workflows
branch
2 times, most recently
from
March 29, 2024 01:37
00c3bf2
to
69cc522
Compare
potiuk
added
the
upgrade to newer dependencies
If set, upgrade to newer dependencies is forced
label
Mar 29, 2024
Reopened to check with upgrade-to-newer-dependencies. |
potiuk
force-pushed
the
hide-internals-of-skipped-workflows
branch
2 times, most recently
from
March 29, 2024 13:23
4a01cd9
to
04567fe
Compare
Should be good to go - seems to pass all the variants |
aritra24
approved these changes
Mar 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a question, but overall looks good
potiuk
added
full tests needed
We need to run full set of tests for this PR to merge
and removed
upgrade to newer dependencies
If set, upgrade to newer dependencies is forced
labels
Mar 29, 2024
potiuk
force-pushed
the
hide-internals-of-skipped-workflows
branch
3 times, most recently
from
March 29, 2024 13:53
61ec66d
to
7187a29
Compare
When the whole workflow can be skipped and it's one of the workflows than nothing depends on, we can skip the whole workflow rather than individual jobs - then the workflow will not be shown as unfolded with all the jobs skipped but as a single skipped workflow. This is what we do for Additional CI image tests and Finalize tests & special tests.
potiuk
force-pushed
the
hide-internals-of-skipped-workflows
branch
from
March 29, 2024 13:53
7187a29
to
d9ba732
Compare
jscheffl
approved these changes
Mar 29, 2024
Merging. the "No pydantic" tests in main will be handled separately (need to skip some more tests in NoPydantic case). |
mathiaHT
pushed a commit
to mathiaHT/airflow
that referenced
this pull request
Apr 4, 2024
When the whole workflow can be skipped and it's one of the workflows than nothing depends on, we can skip the whole workflow rather than individual jobs - then the workflow will not be shown as unfolded with all the jobs skipped but as a single skipped workflow. This is what we do for Additional CI image tests and Finalize tests & special tests.
ephraimbuddy
pushed a commit
that referenced
this pull request
Apr 16, 2024
When the whole workflow can be skipped and it's one of the workflows than nothing depends on, we can skip the whole workflow rather than individual jobs - then the workflow will not be shown as unfolded with all the jobs skipped but as a single skipped workflow. This is what we do for Additional CI image tests and Finalize tests & special tests. (cherry picked from commit 3f4872b)
ephraimbuddy
pushed a commit
that referenced
this pull request
Apr 16, 2024
When the whole workflow can be skipped and it's one of the workflows than nothing depends on, we can skip the whole workflow rather than individual jobs - then the workflow will not be shown as unfolded with all the jobs skipped but as a single skipped workflow. This is what we do for Additional CI image tests and Finalize tests & special tests. (cherry picked from commit 3f4872b)
utkarsharma2
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 22, 2024
When the whole workflow can be skipped and it's one of the workflows than nothing depends on, we can skip the whole workflow rather than individual jobs - then the workflow will not be shown as unfolded with all the jobs skipped but as a single skipped workflow. This is what we do for Additional CI image tests and Finalize tests & special tests.
56 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the whole workflow can be skipped and it's one of the workflows than nothing depends on, we can skip the whole workflow rather than individual jobs - then the workflow will not be shown as unfolded with all the jobs skipped but as a single skipped workflow.
This is what we do for Additional CI image tests and Finalize tests & Special tests
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.