Improve XComObjectStoreBackend implementation #38608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
force-pushed
the
xcom-objectstorage-backend-improvements
branch
2 times, most recently
from
c196629 to
78ec6e4
Compare
jedcunningham
approved these changes
Mar 29, 2024
dirrao
approved these changes
Mar 30, 2024
Repeated configuration access is moved to cached functions so the string literals don't need to be written repeatedly. The path configuration is made mandatory since it more or less is; using this backend without a path configured is most likely an unintended user error. Various functions are rewritten to take advantage of early returns, and more localized try-except blocks to improve code quality.
uranusjr
force-pushed
the
xcom-objectstorage-backend-improvements
branch
from
78ec6e4 to
fbdfedd
Compare
Taragolis
approved these changes
Apr 2, 2024
eladkal
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repeated configuration access is moved to cached functions so the string literals don't need to be written repeatedly. The path configuration is made mandatory since it more or less is; using this backend without a path configured is most likely an unintended user error.
Various functions are rewritten to take advantage of early returns, and more localized try-except blocks to improve code quality.