removed usage of deprecated function for naming the pod in provider k8s pod.py #38638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idantepper
requested review from
jedcunningham and
hussein-awala
as code owners
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
idantepper
changed the title
idantepper
changed the title
|
i am goin over all of them right now, thanks for the respond |
|
i changed a little bit more, i don't want this to be a huge PR, after doing this changes i will continue to change also the other ones |
romsharon98
approved these changes
Mar 31, 2024
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
romsharon98
approved these changes
Mar 31, 2024
amoghrajesh
approved these changes
Apr 1, 2024
idantepper
requested review from
bolkedebruin,
kaxil,
pierrejeambrun,
potiuk,
ashb,
eladkal,
o-nikolas,
dstandish,
uranusjr,
ryanahamilton,
bbovenzi,
ephraimbuddy and
XD-DENG
as code owners
idantepper
force-pushed
the
kubernetes-pod-operator-handle-warnings
branch
from
d8afed6
to
5041b0b
Compare
…before used a deprecated one and now using add_uniqu_suffix()
added 4 commits
April 4, 2024 00:50
…fore used a deprecated one and now using add_uniqe_id()
…nique_id to use add_unique_suffix before it used a deprecated one
…dd_unique_suffix before it used a deprecated one
idantepper
force-pushed
the
kubernetes-pod-operator-handle-warnings
branch
from
5041b0b
to
7506940
Compare
|
hello, after having some issues with my developing environment now everything is done thanks |
hussein-awala
approved these changes
Apr 3, 2024
|
You can check https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst to fix the static checks. |
eladkal
removed request for
ryanahamilton,
ashb,
potiuk,
uranusjr,
ephraimbuddy,
bolkedebruin,
bbovenzi,
kaxil,
XD-DENG,
pierrejeambrun,
dstandish,
o-nikolas and
jedcunningham
|
i ran pre-commit and changed the order of the imports |
eladkal
approved these changes
Apr 4, 2024
utkarsharma2
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 22, 2024
…8s pod.py (apache#38638) * (k8s/operator/pod.py): changed the function used to create pod name, before used a deprecated one and now using add_uniqu_suffix() * (k8s/operator/pod.py): changed the function used to create pod id, before used a deprecated one and now using add_uniqe_id() * (k8s/operator/k8s_helper_functions.py): changed the function create_unique_id to use add_unique_suffix before it used a deprecated one * changed order of imports * (k8s/pod_generator.py): changed the function construct_pod() to use add_unique_suffix before it used a deprecated one * changed imports order in pod_generator --------- Co-authored-by: idantepper@gmail.com <idantepper@github.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(k8s/operator/pod.py): changed the function used to create pod name, before used a deprecated one and now using add_uniqu_suffix()
when executing this command
pytest tests/providers/cncf/kubernetes/operators/test_pod.pyreceived a warning that said we need to change the creation of pod name with a deprecated function
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.