-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cancel_previous_run to DatabricksRunNowOperator #38702
Add cancel_previous_run to DatabricksRunNowOperator #38702
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, it looks great! could you please add a test case for this? Thanks
@Lee-W Added UTs, PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please update the doc here as well? I forget to mention it yesterday 🤦♂️
I just noticed the test is failing. We might need your help to resolve it. Thanks! |
@Lee-W Where can I see test failure logs? |
Scroll down a bit. You should be able to find it here. I just approved the CI run. You can click the detail |
Fixed UTs and tested locally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the prompt fixings! There's one last static check failure and an improvement not directly related to this PR. You can check that locally with breeze static-check
@Lee-W All tests passed. |
cc: @alexott if you could please offer a review here if and when you have time :) |
@potiuk Please review this PR. |
Why tagging me? @SubhamSinghal ? What's the reasoning of doing it ? I think there are enough reviewers. generally please avoid tagging people directly unless you know for sure they will be insterested. Remember that people here participate when they have time and decide to spend their time on some issues - not because someone else decides they should do it. There are cases where people know and agreed upfront to be tagged, but tagging people like that out of the blue is generally a bad idea and try to avoid it, unless you really need it (and know people are interested). |
If you just want to get your PR merged faster, then it's a very selfish reason to tap into time and attention of others when YOU want it and not when THEY have time for it. |
As many have approved this, I plan to merge it today or tomorrow. Please let me know if anyone want to take a deeper look 🙂 |
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Closes: #38695
Adds cancel_previous_runs parameter which will cancel all running jobs before submitting a new one.