Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(airbyte/hooks): add schema and port to prevent InvalidURL error #38860

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

josix
Copy link
Contributor

@josix josix commented Apr 9, 2024

Fix #37449 through adding the schema and port to base_url in get_headers_tenants_from_connection so that aiohttp wouldn't raise the InvalidURL error.

image


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link

boring-cyborg bot commented Apr 9, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@josix josix force-pushed the fix/airbyte/aiohttp-url-error branch from 622a250 to 4978a82 Compare April 9, 2024 10:09
@josix josix marked this pull request as ready for review April 9, 2024 11:27
@josix josix force-pushed the fix/airbyte/aiohttp-url-error branch from 4978a82 to b3c675e Compare April 9, 2024 11:28
Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a parametrized test that covers the possible cases?

@josix josix force-pushed the fix/airbyte/aiohttp-url-error branch from b3c675e to aa18203 Compare April 11, 2024 18:23
@josix josix force-pushed the fix/airbyte/aiohttp-url-error branch from aa18203 to 5aebb1b Compare April 11, 2024 18:31
@josix
Copy link
Contributor Author

josix commented Apr 11, 2024

Hi @hussein-awala thanks for the advise, I've added the test for it. PTAL, thanks.

Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@eladkal eladkal merged commit 725c568 into apache:main Apr 11, 2024
41 checks passed
Copy link

boring-cyborg bot commented Apr 11, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AirbyteTriggerSyncOperator does not work on deferrable mode
3 participants