Fix problem that links in legacy log view can not be clicked #38882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
requested review from
ryanahamilton,
ashb,
bbovenzi and
pierrejeambrun
as code owners
boring-cyborg
bot
added
area:UI
hussein-awala
approved these changes
Apr 9, 2024
potiuk
approved these changes
Apr 10, 2024
jedcunningham
pushed a commit
that referenced
this pull request
Apr 26, 2024
* Remove problems by double-linkification from coloring * Fix problem that links in legacy log view can not be clicked (cherry picked from commit 87acf61)
56 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During production rollout of (my bad) contributions of Airflow 2.9.0 I realized that the links from the text in the legacy log view are generated but not clickable. The event-handler for the log grouping masks them.
This PR fixes the snipped of JavaScript and fixes the "non clickable links".
As making this fix in discussions with others we realized thatthe
ansi_uplibrary also creates links, in order to prevent problems with this in comparison with the link generation we do in the other script code, this PR disables link generation fromansi_up. Double link generation looks strange. Proposing to keep our "existing" regex as this was stable and the result I got fromansi_upwere not directly working, might be a bug in this lib.How to test:
example_bash_operatorDAGrun_after_loop