Fix try_number handling when db isolation enabled #38943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an error in the refresh_from_db code, and because of try_number inconsistency, the same run was going into two different log files. There is some ugliness here, but some ugliness is unavoidable when dealing with try_number as it is right now. (cherry picked from commit 50340786d779244d4c78eb3e3a9d9538679a2ede)
dstandish
requested review from
kaxil,
ashb,
bolkedebruin and
XD-DENG
as code owners
dstandish
commented
Apr 11, 2024
vincbeck
approved these changes
Apr 11, 2024
|
this, dealing, as it does, with try_number, is a weird one, so i'm gonna let it go overnight to see if @uranusjr @potiuk @jedcunningham want to give it a look |
jedcunningham
approved these changes
Apr 11, 2024
hussein-awala
approved these changes
Apr 11, 2024
dirrao
approved these changes
Apr 12, 2024
uranusjr
reviewed
Apr 12, 2024
potiuk
approved these changes
Apr 12, 2024
jedcunningham
added
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an error in the refresh_from_db code, and because of try_number inconsistency, the same run was going into two different log files. There is some ugliness here, but some ugliness is unavoidable when dealing with try_number as it is right now.