Fix SFTPSensor.newer_than not working with jinja logical ds/ts expression #39056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
2 tasks
eladkal
changed the title
dirrao
reviewed
Apr 16, 2024
…-templating' into fix-36629-sftp-sensor-newer-than-templating
…-templating' into fix-36629-sftp-sensor-newer-than-templating
Taragolis
reviewed
Apr 17, 2024
…e#39054) * Prepare docs 1st wave (RC3) + ad hoc April 2024 (apache#38995) * update databricks
…38814) * update docstring for DagBag class * break long line * fix space Signed-off-by: kalyanr <kalyan.ben10@live.com> --------- Signed-off-by: kalyanr <kalyan.ben10@live.com>
The import might be invoked when K8S executor starts with sentry on and it might lead to circular imports Related: apache#31442
We should use the same, non deprecated, version of PodDefaults for the xcom sidecar when creating and reading xcom.
…-templating' into fix-36629-sftp-sensor-newer-than-templating # Conflicts: # airflow/providers/sftp/sensors/sftp.py # tests/providers/sftp/sensors/test_sftp.py
Taragolis
reviewed
May 4, 2024
…-templating' into fix-36629-sftp-sensor-newer-than-templating
…-templating' into fix-36629-sftp-sensor-newer-than-templating
Taragolis
approved these changes
May 6, 2024
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
pateash
pushed a commit
to pateash/airflow
that referenced
this pull request
May 13, 2024
…sion (apache#39056) * Fixes apache#36629 * Fixes PR failed test * Remove an parametrize duplicate tests * Fix formatting * Fix formatting * Fixes apache#36629 * Fixes PR failed test * Remove an parametrize duplicate tests * update simple-salesforce type hints to support 1.12.6 (apache#39047) * Fix formatting * Add changelog for airflow python client 2.9.0 (apache#39060) * Upgrade to latest hatchling as build dependency (apache#39044) * Prepare docs 1st wave (RC3) + ad hoc April 2024 (apache#38995) (apache#39054) * Prepare docs 1st wave (RC3) + ad hoc April 2024 (apache#38995) * update databricks * [docs] update `DagBag` class docstring to include all params (apache#38814) * update docstring for DagBag class * break long line * fix space Signed-off-by: kalyanr <kalyan.ben10@live.com> --------- Signed-off-by: kalyanr <kalyan.ben10@live.com> * Data aware scheduling docs edits (apache#38687) * Moves airflow import in deprecated pod_generator to local (apache#39062) The import might be invoked when K8S executor starts with sentry on and it might lead to circular imports Related: apache#31442 * KPO xcom sidecar PodDefault usage (apache#38951) We should use the same, non deprecated, version of PodDefaults for the xcom sidecar when creating and reading xcom. * Fix formatting * Change date/time parsing method for newer_than parameter un SFTPSensor * Add examples in AWS auth manager documentation (apache#39040) * update document (apache#39068) * Update hatchling to version 1.24.0 (apache#39072) * Check that the dataset<>task exists before trying to render graph (apache#39069) * Change date/time parsing method for newer_than parameter un SFTPSensor * Fix utc timezone in unit tests * Fix utc timezone in unit tests --------- Signed-off-by: kalyanr <kalyan.ben10@live.com> Co-authored-by: Grégoire Rolland <gregoire.rolland@mymoneybank.com> Co-authored-by: Hussein Awala <hussein@awala.fr> Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com> Co-authored-by: Jarek Potiuk <jarek@potiuk.com> Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com> Co-authored-by: Kalyan <kalyan.ben10@live.com> Co-authored-by: Laura Zdanski <25642903+lzdanski@users.noreply.github.com> Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com> Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com> Co-authored-by: humit <jhjang1005@naver.com> Co-authored-by: Brent Bovenzi <brent@astronomer.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #36629
Add str to time transformation in case the newer_than parameter is templated.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.