-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/helm chart: workers.command for KubernetesExecutor #39132
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
55b54aa
to
776f98a
Compare
a195757
to
c9216d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good.
I think we can also add args
label in following PR because it's related to command
.
but it's not that simple because the default value for command
is belong to celery worker.
5935a4c
to
7ebb4a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test for pod_template to check the command isn't set by default?
7ebb4a0
to
237cec3
Compare
237cec3
to
4a44443
Compare
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Thanks @nyirit! Congrats on your first commit 🎉 ! |
Awesome! Thank you @jedcunningham for the help with it! :) |
Helm-chart version used: 1.13.1 (latest)
Airflow version used: 2.8.4
The
workers.command
value override is ignored ifKubernetesExecutor
is used.I wanted to add a custom
command
parameter to the base container in the pods that are created to execute the tasks, but I failed to do so with the following values.yaml override:I have found that this value is only used in the
worker-deployment.yaml
, but not in thepod-template-file.kubernetes-helm-yaml
which seems to be used forKubernetesExecutor
.Based on the
workers.command
documentation this does seem to be a bug.Potential workaround
To make this work and prove that this is actually needed in my case, I have used the following override in the dag definition:
This gets the job done, but it would be a lot nicer to be able to do this from the helm-chart, especially as this should be the default behaviour in my case for each dag.
I have checked open issues, but did not find one that mentions this problem. Also, this is my first PR here, so even against my best intentions, I might have missed something in the contributing guidelines, so all feedback and help is welcome :)
Branch is freshly rebased! :)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.