Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rendered k8s pod spec tab to ti details view #39141

Merged
merged 3 commits into from
May 2, 2024

Conversation

bbovenzi
Copy link
Contributor

@bbovenzi bbovenzi commented Apr 19, 2024

Show Rendered K8s Pod Spec in react as a new tab on task instance details

Screenshot 2024-04-23 at 2 48 35 PM

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Apr 19, 2024
@raphaelauv
Copy link
Contributor

This is great !

Also maybe a toggle to switch between JSON and YAML would be so cool ( same feature than inside the kubernetes dashboard )

@bbovenzi bbovenzi force-pushed the react-rendered-k8s branch from 93d5e7a to 3689537 Compare April 23, 2024 19:41
@bbovenzi bbovenzi marked this pull request as ready for review April 23, 2024 19:49
@bbovenzi bbovenzi added this to the Airflow 2.10.0 milestone Apr 24, 2024
Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! LGTM +1

@bbovenzi bbovenzi merged commit 1074b8e into apache:main May 2, 2024
39 checks passed
@bbovenzi bbovenzi deleted the react-rendered-k8s branch May 2, 2024 15:21
@utkarsharma2 utkarsharma2 added the type:new-feature Changelog: New Features label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:new-feature Changelog: New Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants