Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix BigQueryToMsSqlOperator #39171

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

moiseenkov
Copy link
Contributor

  1. fixed BigQueryToMsSqlOperator - from now on it provides a correct parameter to the MsSqlHook (mssql_conn_id instead of mysql_conn_id);
  2. added unit tests;
  3. adjusted system test so it actually performs data transfer.

@boring-cyborg boring-cyborg bot added area:providers area:system-tests provider:google Google (including GCP) related issues labels Apr 22, 2024
Copy link
Collaborator

@dirrao dirrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@potiuk
Copy link
Member

potiuk commented Apr 23, 2024

One tes to fix

@potiuk potiuk merged commit 4ae85d7 into apache:main Apr 23, 2024
42 checks passed
RodrigoGanancia pushed a commit to RodrigoGanancia/airflow that referenced this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers area:system-tests provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants