feat: skip_when_already_exists TriggerDagRunOperator #39173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
area:core-operators
raphaelauv
force-pushed
the
feat/soft_fail_TriggerDagRunOperator
branch
from
2180556
to
b78cd43
Compare
dirrao
approved these changes
Apr 25, 2024
|
@raphaelauv could you resolve conflicts? |
raphaelauv
force-pushed
the
feat/soft_fail_TriggerDagRunOperator
branch
from
b78cd43
to
04ebcc4
Compare
raphaelauv
force-pushed
the
feat/soft_fail_TriggerDagRunOperator
branch
from
04ebcc4
to
ce3387a
Compare
|
@Taragolis it's done , thanks |
Taragolis
approved these changes
May 6, 2024
raphaelauv
changed the title
pateash
pushed a commit
to pateash/airflow
that referenced
this pull request
May 13, 2024
* feat: soft_fail TriggerDagRunOperator * review_1 --------- Co-authored-by: raphaelauv <raphaelauv@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I have a lot of TriggerDagRunOperator in failed stated ( where some failed before triggering the dag_run and some after ) for any reason ( airflow worker unclean stop .., zombie task ... )
then if I clear all of them , some will be running then success and others will directly fail because dag_run already exists and was correctly trigger
So it's painful to manage this operator at real scaling ( thousands of runs )
with this option we can clear the operator and it will not fail in case the dag_run was correctly trigger