Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Only quote the keys of the query_parameters in MSGraphOperator #39207

Merged
merged 5 commits into from
Apr 24, 2024
Merged

Fix: Only quote the keys of the query_parameters in MSGraphOperator #39207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5f9a7c3
fix: Make sure the encoded_query_parameters function of the MSGraphTr…
davidblain-infrabel Apr 23, 2024
a71468d
Merge branch 'main' into fix/msgraph-encode-query-params
dabla Apr 23, 2024
e6d2b8d
refactor: Added missing coma
davidblain-infrabel Apr 23, 2024
2d7351f
Merge branch 'main' into fix/msgraph-encode-query-params
dabla Apr 24, 2024
7b8eaa5
Merge branch 'main' into fix/msgraph-encode-query-params
dabla Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airflow/providers/microsoft/azure/triggers/msgraph.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ def normalize_url(self) -> str | None:

def encoded_query_parameters(self) -> dict:
if self.query_parameters:
return {quote(key): quote(str(value)) for key, value in self.query_parameters.items()}
return {quote(key): value for key, value in self.query_parameters.items()}
return {}

def request_information(self) -> RequestInformation:
Expand Down
11 changes: 11 additions & 0 deletions tests/providers/microsoft/azure/triggers/test_msgraph.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,17 @@ def test_template_fields(self):
for template_field in MSGraphTrigger.template_fields:
getattr(trigger, template_field)

def test_encoded_query_parameters(self):
trigger = MSGraphTrigger(
url="myorg/admin/groups",
conn_id="msgraph_api",
query_parameters={"$expand": "reports,users,datasets,dataflows,dashboards", "$top": 5000},
)

actual = trigger.encoded_query_parameters()

assert actual == {"%24expand": "reports,users,datasets,dataflows,dashboards", "%24top": 5000}


class TestResponseHandler:
def test_handle_response_async(self):
Expand Down