Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sqa deprecations for airflow core #39211

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

dondaum
Copy link
Contributor

@dondaum dondaum commented Apr 23, 2024

related: #28723

fix deprecations for SQLAlchemy 2.0 for Airflow core.

@Taragolis I linked your changes as well in the list.

Further I have noticed 2 things. First of all I fixed an issue that was not listed in the orginal issue. I assume it might was missing as it a mysql specfic, e.g. example Thus it would make sense to run the checks for mysql and any other supported db as well.

Second I could not fix airflow/cli/commands/task_command.py:202 and I am not really sure if this is really something that needs to be fixed. I went through the SQA docs and it might be a warning we have in 1.4 that will be gone whenever we have 2.0 without any real error. But hard to tell. I will further investigate.

Reported in core


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Apr 23, 2024
@Taragolis
Copy link
Contributor

First of all I fixed an issue that was not listed in the orginal issue. I assume it might was missing as it a mysql specfic, e.g. example Thus it would make sense to run the checks for mysql and any other supported db as well.

In theory it should be run against mysql backend, however difficult to say right now, seems like codecov integration broken again and there is difficult to say is this lines covered or not

Second I could not fix airflow/cli/commands/task_command.py:202 and I am not really sure if this is really something that needs to be fixed. I went through the SQA docs and it might be a warning we have in 1.4 that will be gone whenever we have 2.0 without any real error. But hard to tell. I will further investigate.

This might not work as it expected into the 2.0 but better to check, it could be done by the separate PR. That what I found about particular this warning: sqlalchemy/sqlalchemy#7693 (comment)

@Taragolis Taragolis added the full tests needed We need to run full set of tests for this PR to merge label Apr 24, 2024
@Taragolis
Copy link
Contributor

Set to rerun it with full test just in case

@Taragolis Taragolis closed this Apr 24, 2024
@Taragolis Taragolis reopened this Apr 24, 2024
@dondaum dondaum force-pushed the fix/sqa-deprecations-airflow-core branch from 7c0c116 to 1a315c1 Compare April 24, 2024 13:36
@Taragolis Taragolis added this to the Airflow 2.9.1 milestone Apr 24, 2024
airflow/www/views.py Show resolved Hide resolved
@uranusjr uranusjr merged commit 6cb9def into apache:main Apr 25, 2024
70 checks passed
@jedcunningham jedcunningham removed this from the Airflow 2.9.1 milestone Apr 26, 2024
@utkarsharma2 utkarsharma2 added the type:misc/internal Changelog: Misc changes that should appear in change log label Jun 3, 2024
@utkarsharma2 utkarsharma2 added this to the Airflow 2.10.0 milestone Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:webserver Webserver related Issues full tests needed We need to run full set of tests for this PR to merge type:misc/internal Changelog: Misc changes that should appear in change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants