Fix batching for BigQueryToPostgresOperator #39233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
area:system-tests
provider:google
moiseenkov
force-pushed
the
bigquery_to_postgres_fix_batch
branch
3 times, most recently
from
b7ea281
to
f12a935
Compare
moiseenkov
force-pushed
the
bigquery_to_postgres_fix_batch
branch
from
f12a935
to
9017c15
Compare
eladkal
approved these changes
Apr 27, 2024
66 tasks
|
Performance is still very poor. Opened new ticket #40948 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed batching for the following operators:
Previously, if users specify the
batch_sizeparameter it is used only for reading from the BigQuery, however, the writing to the database is performed with the default batch size of 1000 rows. This PR fixes that and the specifiedbatch_sizenow used for both reading from BigQuery and writing to a database.Additionally, updated the system test.