Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix trigger kwarg encryption migration #39246

Merged
merged 4 commits into from
Apr 25, 2024
Merged

Fix trigger kwarg encryption migration #39246

merged 4 commits into from
Apr 25, 2024

Commits on Apr 25, 2024

  1. Fix trigger encryption migration 

    Do the encryption in the migration itself, and fix support for offline
migrations as well.

The offline up migration won't actually encrypt the trigger kwargs as there
isn't a safe way to accomplish that, so the decryption processes checks
and short circuits if it isn't encrypted.

The offline down migration will now print out a warning that the offline
migration will fail if there are any running triggers. I think this is
the best we can do for that scenario (and folks willing to do offline
migrations will hopefully be able to understand the situation).

This also solves the "encrypting the already encrypted kwargs" bug in
2.9.0.
    @jedcunningham @Lee-W
    jedcunningham authored and Lee-W committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    aef8938 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review

    @jedcunningham @Lee-W
    jedcunningham authored and Lee-W committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    e8e9e30 View commit details
    Browse the repository at this point in the history

  3. Fix migration for main vs v2-9-stable

    @jedcunningham @Lee-W
    jedcunningham authored and Lee-W committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    d40f922 View commit details
    Browse the repository at this point in the history

  4. docs: regenerate airflow_erd

    @Lee-W
    Lee-W committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    f2fd7a8 View commit details
    Browse the repository at this point in the history