Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "matchExpressions" for "nodeAffinity" #39255

Closed
wants to merge 1 commit into from

Conversation

chs2
Copy link

@chs2 chs2 commented Apr 25, 2024

No description provided.

Copy link

boring-cyborg bot commented Apr 25, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@amoghrajesh
Copy link
Contributor

@chs2 can you please update the PR description? Its hard to tell what you are trying to achieve without a description

Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matchExpressions should be an array of expressions, LGTM

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Jun 16, 2024
@amoghrajesh
Copy link
Contributor

@chs2 are you working on this actively? Requires small nit handling and a rebase (doing it)

@amoghrajesh amoghrajesh reopened this Jun 17, 2024
@amoghrajesh
Copy link
Contributor

Reopened to run the latest set of CI on the PR

@chs2
Copy link
Author

chs2 commented Jun 17, 2024

@chs2 are you working on this actively? Requires small nit handling and a rebase (doing it)

To be true, no I'm not.
I wouldn't have thought it would raise so many questions.
While working on a airflow1-to-airflow2 migration I found the Airflow1 KubernetesPodOperator documentation. I noticed the typo and thought it would be nice to have it fixed for anyone in the same situation.

@eladkal
Copy link
Contributor

eladkal commented Jun 17, 2024

Ah wait
This PR is targeted the v-10-stable branch. This is why it was confusing.
We are not having any more releases for Airflow 1.10

@potiuk
Copy link
Member

potiuk commented Jun 17, 2024

Ah yes.

@potiuk potiuk closed this Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:documentation stale Stale PRs per the .github/workflows/stale.yml policy file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants