Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added logical_date parameter #39285

Merged
merged 3 commits into from
Apr 27, 2024
Merged

added logical_date parameter #39285

merged 3 commits into from
Apr 27, 2024

Conversation

flolas
Copy link
Contributor

@flolas flolas commented Apr 27, 2024 •
edited
Loading

Closes: #26916

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:core-operators Operators, Sensors and hooks within Core Airflow label Apr 27, 2024
@dirrao dirrao requested a review from potiuk April 27, 2024 03:58
dirrao
dirrao approved these changes Apr 27, 2024
View reviewed changes
Copy link
Contributor

@dirrao dirrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would like someone to take a look at on deprecation details.

@eladkal eladkal added this to the Airflow 2.9.1 milestone Apr 27, 2024
@eladkal eladkal merged commit c946fc3 into apache:main Apr 27, 2024
39 checks passed
@ephraimbuddy ephraimbuddy added type:bug-fix Changelog: Bug Fixes type:misc/internal Changelog: Misc changes that should appear in change log and removed type:bug-fix Changelog: Bug Fixes labels Apr 29, 2024
ephraimbuddy pushed a commit that referenced this pull request Apr 29, 2024
@flolas @ephraimbuddy
TriggerDagRunOperator depreacte exection_date in favor of `logica…
8b3c24f 
…l_date` (#39285)

* added logical_date parameter

* fix comment

(cherry picked from commit c946fc3)
@ephraimbuddy ephraimbuddy mentioned this pull request Apr 30, 2024
Closed
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladkal eladkal eladkal approved these changes

@dirrao dirrao dirrao approved these changes

@hussein-awala hussein-awala hussein-awala approved these changes

@potiuk potiuk Awaiting requested review from potiuk

Assignees
No one assigned
Labels
area:core-operators Operators, Sensors and hooks within Core Airflow type:misc/internal Changelog: Misc changes that should appear in change log
Projects
None yet
Milestone
Airflow 2.9.1
Development

Successfully merging this pull request may close these issues.

Align TriggerDagRunOperator with logical date terminology
5 participants
@flolas @hussein-awala @dirrao @eladkal @ephraimbuddy