Scheduler to handle incrementing of try_number #39336
Merged
Commits on May 8, 2024
-
Refactor tests re sensor reschedule mode and try_number
It's a little clearer what's going on when we're not in a loop or behind an `assert...` helper function. Additionally I add asserts immediately after calling `clear`. This will make it easier to review changes when we attempt to fix try_number shenanigans.
-
Previously, there was a lot of bad stuff happening around try_number. We incremented it when task started running. And because of that, we had this logic to return "_try_number + 1" when task *not* running. And, since it was naively incremented when task starts running -- i.e. without regard to why it is running -- we *decremented* it when deferring or exiting on a reschedule. What I do here is try to remove *all* of that stuff: * no more private _try_number attr * no more getter logic * no more decrementing * no more incrementing as part of task execution Now what we do is increment only when the task is set to *scheduled* and only when it's not coming out of deferral or "up_for_reschedule".
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
Apply suggestions from code review
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
-
Apply suggestions from code review
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.