Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the pinecone system test #39365

Merged
merged 6 commits into from
May 6, 2024
Merged

Fix the pinecone system test #39365

merged 6 commits into from
May 6, 2024

Conversation

sunank200
Copy link
Collaborator

@sunank200 sunank200 commented May 2, 2024

Pinecone system test are failing as specs is missing while creating the index in Pinecone.

Tested the example DAG
Screenshot 2024-05-06 at 1 16 32 PM


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link
Collaborator

@rawwar rawwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! They look good to me!

@sunank200 sunank200 requested a review from pankajkoti May 6, 2024 08:40
@phanikumv phanikumv merged commit 2481b7d into apache:main May 6, 2024
40 checks passed
@phanikumv phanikumv deleted the pinecone_fix branch May 6, 2024 09:56
pateash pushed a commit to pateash/airflow that referenced this pull request May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants