Add hatch_build.py to k8s test venv cache calculation #39473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
added
the
full tests needed
kaxil
approved these changes
May 7, 2024
potiuk
force-pushed
the
fix-caching-hash-for-k8s-tests
branch
from
85ae01a
to
b56d323
Compare
|
Also added it to |
kaxil
approved these changes
May 7, 2024
eladkal
approved these changes
May 7, 2024
jedcunningham
approved these changes
May 7, 2024
potiuk
force-pushed
the
fix-caching-hash-for-k8s-tests
branch
from
b56d323
to
5c0b058
Compare
|
Actuallly ... we can safely remove pyproject.toml since all our dependencies and extras are dynamic and coming from |
|
(will avoid unnecessary recreation of envs when only some tool options chane - like ruff rules) |
With dynamic project depdencies, the requirements for airlfow are calculated dymamically from hatch_build.py, however cache invalidation key for k8s tests only included pyproject.toml so when colorlog has been bumped in @39453, main build continued to use cache from old colorlog. This PR adds also hatch_build.py to cache id calculation
potiuk
force-pushed
the
fix-caching-hash-for-k8s-tests
branch
from
5c0b058
to
e5272c2
Compare
pateash
pushed a commit
to pateash/airflow
that referenced
this pull request
May 13, 2024
With dynamic project depdencies, the requirements for airlfow are calculated dymamically from hatch_build.py, however cache invalidation key for k8s tests only included pyproject.toml so when colorlog has been bumped in @39453, main build continued to use cache from old colorlog. This PR adds also hatch_build.py to cache id calculation
ephraimbuddy
pushed a commit
that referenced
this pull request
Jun 5, 2024
With dynamic project depdencies, the requirements for airlfow are calculated dymamically from hatch_build.py, however cache invalidation key for k8s tests only included pyproject.toml so when colorlog has been bumped in @39453, main build continued to use cache from old colorlog. This PR adds also hatch_build.py to cache id calculation (cherry picked from commit f5c86ed)
41 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With dynamic project depdencies, the requirements for airlfow are calculated dymamically from hatch_build.py, however cache invalidation key for k8s tests only included pyproject.toml so when colorlog has been bumped in @39453, main build continued to use cache from old colorlog.
This PR adds also hatch_build.py to cache id calculation
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.