-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amazon Bedrock - Retrieve and RetrieveAndGenerate #39500
Merged
o-nikolas
merged 7 commits into
apache:main
from
aws-mwaa:ferruzzi/bedrock/m6-bedrock-rag
May 15, 2024
Merged
Amazon Bedrock - Retrieve and RetrieveAndGenerate #39500
o-nikolas
merged 7 commits into
apache:main
from
aws-mwaa:ferruzzi/bedrock/m6-bedrock-rag
May 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
area:system-tests
kind:documentation
provider:amazon-aws
AWS/Amazon - related issues
labels
May 8, 2024
ferruzzi
force-pushed
the
ferruzzi/bedrock/m6-bedrock-rag
branch
from
May 8, 2024 21:17
87c3f83
to
65453f4
Compare
ferruzzi
changed the title
Amaazon Bedrock - Retrieve and RetrieveAndGenerate
Amazon Bedrock - Retrieve and RetrieveAndGenerate
May 8, 2024
o-nikolas
reviewed
May 9, 2024
Ran it using the system test trigger script and it passes with the external sources getting skipped:
|
o-nikolas
approved these changes
May 15, 2024
2 tasks
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
Both of these calls are super fast and neither has any kind of waiter or means of checking the status, so here can not be any sensor or trigger for them. They are simple client calls, but I think making these Operators allowed us to simplify the complicated formatting on the client API call itself, for a better UX.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both of these calls are super fast and neither has any kind of waiter or means of checking the status, so here can not be any sensor or trigger for them. They are simple client calls, but I think making these Operators allowed us to simplify the complicated formatting on the client API call itself, for a better UX.
One question I have is the parameter name for
input
andquery
. I feel like these should be standardized, but also we usually go out of our way to stick as close as possible to the API call's parameter names. Let me know what you think. For InvokeModel I used "input_data", I could standardize all three on that name or just leave them as I have here.All related unit tets, CI, and build-docs pass locally.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.