Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BigQuery jobs Label Regex #39556

Closed
wants to merge 2 commits into from

Conversation

pocky13
Copy link

@pocky13 pocky13 commented May 11, 2024

#37736 Add label DAG ID and Task ID to BigQuery jobs.
However, the maximum label length is 63 characters (see: https://cloud.google.com/bigquery/docs/labels-intro#requirements). Therefore, if the DAG ID or Task ID length is 64, this causes an invalid label exception.
This PR fixes that issue.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels May 11, 2024
Copy link

boring-cyborg bot commented May 11, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@pocky13 pocky13 changed the title Fix BigQuery jobs Labl Regex Fix BigQuery jobs Label Regex May 11, 2024
@eladkal
Copy link
Contributor

eladkal commented May 11, 2024

Can you add unit test to avoid regression?

@eladkal
Copy link
Contributor

eladkal commented May 12, 2024

Another PR that try to solve the same bug
#39568

@pocky13 pocky13 closed this May 12, 2024
@shahar1
Copy link
Contributor

shahar1 commented May 12, 2024

@pocky13 this is actually the more precise fix for now, as the docs state:

label keys and values can be no longer than 63 characters, can only contain lowercase letters, numeric characters, underscores and dashes. International characters are allowed. Label values are optional. Label keys must start with a letter and each label in the list must have a different key. 

In #39568, the regex currently looks like this
LABEL_REGEX = re.compile(r"^[\w-]{0,63}$")
which lets the first character to be an invalid character.

Edit: valid only for the key as explained in the 2nd PR.

@eladkal eladkal reopened this May 12, 2024
@eladkal
Copy link
Contributor

eladkal commented May 12, 2024

Thank you for your contribution.
#39568 solved the bug

@eladkal eladkal closed this May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants