-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Amazon Comprehend Service #39592
Introduce Amazon Comprehend Service #39592
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good job! Thanks for following the good practises and everything. I just added one question but overall it is really good!
…erator to test_project_structure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an awesome PR! Super thorough and ticks all the boxes. We'll use this as an example for future folks, great work! 😃
Thank you so much for reviewing this 😄 , Applied all your feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome PR!
Thank you @vincbeck 😃 |
Added Amazon Comprehend Start Pii Entities Detection Job Operator Doc, Hook,
Operator, Sensor, Trigger, Waiter, Unit Test, System Test.
At present it supports only Pii Entities Detection Job. Remaining Comprehend services coming next.
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/comprehend/client/start_pii_entities_detection_job.html
Sample Dag:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.