Fix oss key prefix bug in oss_task_handler, alibaba-provider #39627
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug discussed in #35654
Sorry for the late fix, I was quite busy at that time when the discussion started. But I think it is better late than never : )
In
oss_task_handler
ofalibaba-provider
,oss_write()
passes the key with prefix intooss_log_exists()
, which duplicately adds the same prefix. This PR fixes the bug and related UT cases.airflow/airflow/providers/alibaba/cloud/log/oss_task_handler.py
Lines 173 to 175 in f411c14
airflow/airflow/providers/alibaba/cloud/log/oss_task_handler.py
Lines 132 to 139 in f411c14
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.