Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove parent_model version suffix if passed to Vertex AI operators #39640

Conversation

e-galan
Copy link
Contributor

@e-galan e-galan commented May 15, 2024

Check the parent_model parameter for model version suffix (looks like <model_id>@1 or <model_name>@1) and remove it from the parent_model string if it is present there. Keep the same value if the suffix is not present.

This is needed because sometimes operators can be passed with the parent_model value which contains such a suffix, for example when the user wants to extract a model id / model name from a serialized result of CreateCustomTrainingJobOperator run and then pass it to another operator as the parent_model. Vertex AI is not able to find a resource if it contains this suffix, and will return an error that will prevent the user from submitting a new training job.

This PR partially reverts #38417 which removed a similar functionality because it caused a bug in the cases when the parent_model did not contain any suffixes. This PR should cover both problems.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@VladaZakharova
Copy link
Contributor

Hi @eladkal !
Can we check this PR and include it to next google-provider release? Thanks!

@eladkal eladkal merged commit 74c3fb3 into apache:main May 17, 2024
40 checks passed
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants