Remove parent_model version suffix if passed to Vertex AI operators #39640
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check the parent_model parameter for model version suffix (looks like <model_id>@1 or <model_name>@1) and remove it from the parent_model string if it is present there. Keep the same value if the suffix is not present.
This is needed because sometimes operators can be passed with the parent_model value which contains such a suffix, for example when the user wants to extract a model id / model name from a serialized result of CreateCustomTrainingJobOperator run and then pass it to another operator as the parent_model. Vertex AI is not able to find a resource if it contains this suffix, and will return an error that will prevent the user from submitting a new training job.
This PR partially reverts #38417 which removed a similar functionality because it caused a bug in the cases when the parent_model did not contain any suffixes. This PR should cover both problems.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.