Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reroute AutoML operator links to Google Translation links #39668

Merged
merged 1 commit into from
May 22, 2024

Conversation

e-galan
Copy link
Contributor

@e-galan e-galan commented May 16, 2024

Update deprecated AutoML operators with new links. Due to its future deprecation AutoML's URLs have been divided between Google Translation and Vertex AI services. This PR updates the operators that are going to be used only with Google Translation services.

I opted to create a new module airflow/providers/google/cloud/links/translate.py and put the new links there instead of updating the existing AutoML links in airflow/providers/google/cloud/links/automl.py because:

  • The links are leading to Google Translation URLs anyway;
  • Corresponding AutoML URLs are no longer accessible and will be deprecated in the future;
  • There is no module for the Google Translation links yet even though Google Translation operators exist.

This PR is dependent on and should not be merged before #38673 .


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels May 16, 2024
airflow/providers/google/cloud/links/automl.py Outdated Show resolved Hide resolved
airflow/providers/google/cloud/links/automl.py Outdated Show resolved Hide resolved
airflow/providers/google/cloud/links/automl.py Outdated Show resolved Hide resolved
airflow/providers/google/cloud/links/automl.py Outdated Show resolved Hide resolved
airflow/providers/google/cloud/links/translate.py Outdated Show resolved Hide resolved
@VladaZakharova
Copy link
Contributor

Hi @potiuk !
Can you please merge changes from here? I guess they were reviewed :)

@potiuk potiuk merged commit 8d5b434 into apache:main May 22, 2024
41 checks passed
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants