Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve typing for allowed/failed_states in TriggerDagRunOperator #39855

Merged
merged 1 commit into from
May 26, 2024

Conversation

josh-fell
Copy link
Contributor

This surfaces another explicit option when specifying allowed_states and/or failed_states -- using the DagRunState enum -- when DAG authors look at the Python API docs for this operator. Also added some clarifying details in the docstring for these parameters too.

@boring-cyborg boring-cyborg bot added the area:core-operators Operators, Sensors and hooks within Core Airflow label May 26, 2024
This surfaces another explicit option when specifying `allowed_states` and/or `failed_states` -- using the DagRunState enum -- when DAG authors look at the Python API docs for this operator. Also added some clarifying details in the docstring for these parameters too.
@josh-fell josh-fell force-pushed the typing-triggerdagrunstates branch from e6ed24a to 54abfac Compare May 26, 2024 18:05
@potiuk potiuk merged commit ad7cb99 into apache:main May 26, 2024
39 checks passed
@josh-fell josh-fell deleted the typing-triggerdagrunstates branch May 26, 2024 23:23
@utkarsharma2 utkarsharma2 added the type:improvement Changelog: Improvements label Jun 3, 2024
@utkarsharma2 utkarsharma2 added this to the Airflow 2.10.0 milestone Jun 3, 2024
fdemiane pushed a commit to fdemiane/airflow that referenced this pull request Jun 6, 2024
…ache#39855)

This surfaces another explicit option when specifying `allowed_states` and/or `failed_states` -- using the DagRunState enum -- when DAG authors look at the Python API docs for this operator. Also added some clarifying details in the docstring for these parameters too.
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
…ache#39855)

This surfaces another explicit option when specifying `allowed_states` and/or `failed_states` -- using the DagRunState enum -- when DAG authors look at the Python API docs for this operator. Also added some clarifying details in the docstring for these parameters too.
@utkarsharma2 utkarsharma2 added type:misc/internal Changelog: Misc changes that should appear in change log and removed type:improvement Changelog: Improvements labels Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core-operators Operators, Sensors and hooks within Core Airflow type:misc/internal Changelog: Misc changes that should appear in change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants