Add a warning message to KPO to warn of one second interval logs duplication #39861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
|
I opened this pull request for #39236 pull request, but I am not really sure if this is the correct way to go, as this is a rare occurrence, and logs might get polluted (space consumed is minimal, but still). What do you think? |
dirrao
approved these changes
May 27, 2024
hussein-awala
approved these changes
May 27, 2024
eladkal
approved these changes
May 27, 2024
20 tasks
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a warning message to KPO to warn of one second interval logs duplication.
The KubernetesPodOperator is duplicating the last one second logs when a pod is interrupted, and this is because the logs reading method in the Kubernetes python client takes a since_seconds parameter, and doesn't support passing a finer-grained time representation (See here for context). The optimal fix requires a change in Kubernetes Python client.
As a quick win, we added a warning message to warn users that logs that the last second logs before the container was interrupted might get duplicated.
closes: #39236
related: #33500