ECS Overrides for AWS Batch submit_job #39903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon-aws
yehoshuadimarsky
force-pushed
the
aws-batch-ecs-overrides
branch
from
e3d4a78
to
c36ea48
Compare
|
Why are the Celery integration tests failing? Seems fully unrelated |
|
Now some random SQL errors in CI |
yehoshuadimarsky
force-pushed
the
aws-batch-ecs-overrides
branch
from
fa8a6cb
to
02d14c8
Compare
|
Is there any way to re-run a failed CI check? These seem flaky |
I reran it |
eladkal
approved these changes
May 29, 2024
20 tasks
fdemiane
pushed a commit
to fdemiane/airflow
that referenced
this pull request
Jun 6, 2024
This was referenced Jun 7, 2024
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying Batch Boto3 method
submit_jobexposes 4 types of overrides that can be specified:containerOverridesnodeOverrideseksPropertiesOverride(singular, no trailings)ecsPropertiesOverride(singular, no trailings)However, the AWS Batch Operator currently only supports only supports overrides for
container_overridesandnode_overrides. This PR adds support to also acceptecs_properties_override. (I did not add EKS support, I don't use it, someone is welcome to).^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.