Improve trigger UI for string array format validation #39993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techolga
requested review from
ryanahamilton,
ashb,
bbovenzi and
pierrejeambrun
as code owners
boring-cyborg
bot
added
area:UI
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
techolga
force-pushed
the
trigger-ui-array-format-validation
branch
from
946ac7a
to
840cb98
Compare
techolga
changed the title
techolga
force-pushed
the
trigger-ui-array-format-validation
branch
from
840cb98
to
dad4f43
Compare
2 tasks
jscheffl
reviewed
Jun 2, 2024
techolga
force-pushed
the
trigger-ui-array-format-validation
branch
2 times, most recently
from
4138fc3
to
4951194
Compare
The schema argument in a Param definition is used to detemine the relevant UI element. When the type of a Param is `array` a simple textarea is rendered. When additionally a schema for the items of the array is provided, the UI element previously switched to a CodeMirror box that expects pure JSON inputs. For strings a textarea is presented now, to keep the same behaviour than without a format definition. Besides that the jinja template now accesses the `items` member of the schema correctly to avoid problems with empty `items` arrays.
techolga
force-pushed
the
trigger-ui-array-format-validation
branch
from
2f9ecc9
to
b4b2930
Compare
jscheffl
approved these changes
Jun 4, 2024
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
fdemiane
pushed a commit
to fdemiane/airflow
that referenced
this pull request
Jun 6, 2024
* Improve trigger UI for string array format validation The schema argument in a Param definition is used to detemine the relevant UI element. When the type of a Param is `array` a simple textarea is rendered. When additionally a schema for the items of the array is provided, the UI element previously switched to a CodeMirror box that expects pure JSON inputs. For strings a textarea is presented now, to keep the same behaviour than without a format definition. Besides that the jinja template now accesses the `items` member of the schema correctly to avoid problems with empty `items` arrays. * Add details about the attribute `items` for the type `array`
syedahsn
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Jun 7, 2024
* Improve trigger UI for string array format validation The schema argument in a Param definition is used to detemine the relevant UI element. When the type of a Param is `array` a simple textarea is rendered. When additionally a schema for the items of the array is provided, the UI element previously switched to a CodeMirror box that expects pure JSON inputs. For strings a textarea is presented now, to keep the same behaviour than without a format definition. Besides that the jinja template now accesses the `items` member of the schema correctly to avoid problems with empty `items` arrays. * Add details about the attribute `items` for the type `array`
utkarsharma2
pushed a commit
that referenced
this pull request
Jul 2, 2024
* Improve trigger UI for string array format validation The schema argument in a Param definition is used to detemine the relevant UI element. When the type of a Param is `array` a simple textarea is rendered. When additionally a schema for the items of the array is provided, the UI element previously switched to a CodeMirror box that expects pure JSON inputs. For strings a textarea is presented now, to keep the same behaviour than without a format definition. Besides that the jinja template now accesses the `items` member of the schema correctly to avoid problems with empty `items` arrays. * Add details about the attribute `items` for the type `array` (cherry picked from commit 914bccc)
35 tasks
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
* Improve trigger UI for string array format validation The schema argument in a Param definition is used to detemine the relevant UI element. When the type of a Param is `array` a simple textarea is rendered. When additionally a schema for the items of the array is provided, the UI element previously switched to a CodeMirror box that expects pure JSON inputs. For strings a textarea is presented now, to keep the same behaviour than without a format definition. Besides that the jinja template now accesses the `items` member of the schema correctly to avoid problems with empty `items` arrays. * Add details about the attribute `items` for the type `array`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #39972
The schema argument in a Param definition is used to detemine the
relevant UI element. When the type of a Param is
arraya simpletextarea is rendered. When additionally a schema for the items of
the array is provided, the UI element previously switched to a
CodeMirror box that expects pure JSON inputs. For strings a textarea
is presented now, to keep the same behaviour than without a format
definition.
Besides that the jinja template now accesses the
itemsmember of the schema correctly to avoid problems with emptyitemsarrays.