Fixing exception types to include TypeError, which is what is raised in #40012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
|
Can you add unit test to avoid regression? |
|
@eladkal sure thing. May be a little bit as I've got a busy week coming up, but I will add a unit test for this. EDIT: @o-nikolas added a unit test for this in #40035. |
vincbeck
approved these changes
Jun 3, 2024
potiuk
approved these changes
Jun 4, 2024
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
ephraimbuddy
added
the
changelog:skip
o-nikolas
added a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Jun 4, 2024
A unit test which triggers the scenario of a current Celery executor with the new signature of change_state run against an older version of Airflow with the old signature of change_state on the BaseExecutor class. related apache#40011 related apache#39980 related apache#40012
eladkal
removed
the
changelog:skip
41 tasks
fdemiane
pushed a commit
to fdemiane/airflow
that referenced
this pull request
Jun 6, 2024
…in (apache#40012) Python 3.12. Fixes apache#40011 Co-authored-by: leake <carl.leake@jpl.nasa.gov>
fdemiane
pushed a commit
to fdemiane/airflow
that referenced
this pull request
Jun 6, 2024
A unit test which triggers the scenario of a current Celery executor with the new signature of change_state run against an older version of Airflow with the old signature of change_state on the BaseExecutor class. related apache#40011 related apache#39980 related apache#40012
27 tasks
syedahsn
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Jun 7, 2024
…in (apache#40012) Python 3.12. Fixes apache#40011 Co-authored-by: leake <carl.leake@jpl.nasa.gov>
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
…in (apache#40012) Python 3.12. Fixes apache#40011 Co-authored-by: leake <carl.leake@jpl.nasa.gov>
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
A unit test which triggers the scenario of a current Celery executor with the new signature of change_state run against an older version of Airflow with the old signature of change_state on the BaseExecutor class. related apache#40011 related apache#39980 related apache#40012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #40011
related: #39980
This issue closes #40011. It modifies the exception line to include
TypeErrorin addition toAttributeError. In Python 3.12, the error that this exception is trying to catch is raised as aTypeErrorrather than anAttributeError.