Move Post Execution Log Grouping behind Exception Print #40146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
added
area:UI
potiuk
approved these changes
Jun 8, 2024
eladkal
approved these changes
Jun 8, 2024
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #38021 we added log grouping into log printing. We all love this feature but I got some negative feedback for cases where people look for a failed task: If you are not an Airflow expert and you look for the exception/eror in the logs, in many cases the exception is not printed. If the task execution fails in an exception the exception trace will be in the "Post task execution logs" group that you need to un-fold.
This PR moves the "Post task execution logs" behind the exception print. Side effect is (due to placement) that error handling code might be called before (on success/skip handler will be called after/inside the group though).
Before - no exception in failed task:
...and you needed to un-fold to see it - note that on_failure_callback is also executed before post block:
After - exception is moved in front of log group:
Plus tasks without exception have no change in beautiful text:
