Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIP 64: Add TI try history to Task Instance Details, Logs, and Gantt chart #40304

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

bbovenzi
Copy link
Contributor

Use the TI History endpoint to expand upon the "log attempts" buttons we had for task logs.

First, show the state of each try next to the number.
Screenshot 2024-06-18 at 12 03 43 PM

Second, add the try selector to the details view too so one can see more information for each try.
Screenshot 2024-06-18 at 12 03 53 PM

Finally, update the Gantt chart to show previous tries.
Screenshot 2024-06-18 at 12 04 05 PM


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@bbovenzi bbovenzi added this to the Airflow 2.10.0 milestone Jun 18, 2024
@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Jun 18, 2024
Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! LGTM

@phanikumv phanikumv merged commit 25132c9 into apache:main Jun 20, 2024
49 checks passed
@phanikumv phanikumv deleted the ti-history-ui branch June 20, 2024 07:39
@jscheffl
Copy link
Contributor

jscheffl commented Jun 22, 2024

@bbovenzi Thanks for the cool UI improvement! I believe I found some bugs but am not sure whether it is related to this?

  1. Have a task which was success, was resetting this is in state scheduled

1.1 Click on 2nd attempt - note that scheduled state is with first icon, 2nd has no state!
image

1.2 Click on 1st attempt - was actually a success in first attempt but state of version icon is scheduled!
image

Was hitting F5 multiple times, no change. Browser: Firefox on Ubuntu - Same with Chromium

  1. A task which was success, shows as success in grid - but status in details is "no status":
    image
    Interestingly: I can correct the behavior if I go to the run before with the two attempts, select attempt 1 there and flip back to the second run... Somehow the details panel run attempt is linked to the previous selection?

image

@jedcunningham jedcunningham added the AIP-64 Task Instance history label Jun 24, 2024
@utkarsharma2 utkarsharma2 added the type:improvement Changelog: Improvements label Jul 1, 2024
@ephraimbuddy ephraimbuddy added changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) and removed type:improvement Changelog: Improvements labels Jul 24, 2024
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AIP-64 Task Instance history area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants