-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AIP 64: Add TI try history to Task Instance Details, Logs, and Gantt chart #40304
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! LGTM
@bbovenzi Thanks for the cool UI improvement! I believe I found some bugs but am not sure whether it is related to this?
1.1 Click on 2nd attempt - note that scheduled state is with first icon, 2nd has no state! 1.2 Click on 1st attempt - was actually a success in first attempt but state of version icon is scheduled! Was hitting F5 multiple times, no change. Browser: Firefox on Ubuntu - Same with Chromium
|
Use the TI History endpoint to expand upon the "log attempts" buttons we had for task logs.
First, show the state of each try next to the number.
Second, add the try selector to the details view too so one can see more information for each try.
Finally, update the Gantt chart to show previous tries.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.