Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/fix support azure managed identities in Databricks operator #40332

Merged

Conversation

marcel-martinelli
Copy link
Contributor

Fixes: #38762


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link

boring-cyborg bot commented Jun 19, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@eladkal eladkal requested a review from Lee-W June 20, 2024 10:24
@marcel-martinelli marcel-martinelli force-pushed the dbx-provider-using-azure-identity branch 2 times, most recently from 86b3545 to 6f21caa Compare June 20, 2024 15:15
Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, but we'll need to fix the failed tests and add some unit tests to this change

@marcel-martinelli
Copy link
Contributor Author

The changes look good, but we'll need to fix the failed tests and add some unit tests to this change

I'm working on fixing the tests. I hope to have it done today.

@Lee-W
Copy link
Member

Lee-W commented Jun 21, 2024

The changes look good, but we'll need to fix the failed tests and add some unit tests to this change

I'm working on fixing the tests. I hope to have it done today.

No worries. 🙂

@marcel-martinelli marcel-martinelli force-pushed the dbx-provider-using-azure-identity branch from 58e125b to 9408428 Compare June 21, 2024 17:13
@potiuk potiuk merged commit de5c751 into apache:main Jun 22, 2024
52 checks passed
Copy link

boring-cyborg bot commented Jun 22, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
…he#40332)

* Add azure identity to get bearer token

* Add azure-identity as an additional-extras dependency

* Fix tests

---------

Co-authored-by: Marcel Martinelli <marcel.martinelli@rabobank.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Databricks provider does not support Azure managed identity if more than one identity exists (e.g. ADF, AKS)
4 participants