-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADD git-sync container lifecycle hooks #40369
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add this to values.yaml
and values.schema.json
?
That is already in values.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats on your first PR. LGTM
What if there is a global |
@nevcohen
It works same as other container hooks. |
Looks like static checks are failing. I'd also suggest that you set up the pre-commit hooks, they help catch these issues early 👍. |
thanks. i fixed it |
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
* ADD git-sync container lifecycle hooks * disable on git-sync-init container * add unit test * add unit test * add global lifecycle hook condition * make test pass * disable .Values.containerLifecycleHooks * pass static checks
Closes: #40364