Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added chunk_size parameter to LocalFilesystemToGCSOperator #40379

Merged
merged 11 commits into from
Jun 23, 2024

Conversation

jsjasonseba
Copy link
Contributor

closes: #38958
related: #38958

This PR added a chunk_size parameter to the LocalFilesystemToGCSOperator. This parameter is already implemented in the GCSHook.upload function. This change ensures that the chunk_size is passed to the upload function.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers kind:documentation provider:google Google (including GCP) related issues labels Jun 22, 2024
Copy link

boring-cyborg bot commented Jun 22, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@potiuk
Copy link
Member

potiuk commented Jun 22, 2024

Some spell-check issue.

@jsjasonseba
Copy link
Contributor Author

It seems like the spell-check detects 'KiB' as an invalid term, even tough it should be valid. I have removed it.

@potiuk
Copy link
Member

potiuk commented Jun 22, 2024

There is a list of allowed words. KiB is not on it. you can add it there, or you can KiB quote the word to avoid spellchecking it.

@jsjasonseba
Copy link
Contributor Author

I wasn't aware of the list of allowed words. Let me add it to the list. Thanks for letting me know.

@potiuk potiuk merged commit 68a87f7 into apache:main Jun 23, 2024
51 checks passed
Copy link

boring-cyborg bot commented Jun 23, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@potiuk
Copy link
Member

potiuk commented Jun 23, 2024

And merged :)

@utkarsharma2 utkarsharma2 added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jul 1, 2024
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) kind:documentation provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add blob size to LocalFilesystemToGCSOperator
4 participants