Move import to make PythonOperator working on Windows #40424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
area:core-operators
hussein-awala
approved these changes
Jun 25, 2024
potiuk
approved these changes
Jun 26, 2024
potiuk
force-pushed
the
bugfix/10388-move-import-for-windows-compatability
branch
from
0a7c454
to
b4143a9
Compare
|
Rebasing... The twine issue was caused by pypa/twine#1125 that made twine maintainer to yank 5.1.0 and release 5.1.1 2 hours ago. |
|
@potiuk Thanks for the rebase-as-a-service, made it :-D |
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
ephraimbuddy
added
type:bug-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was testing the PoC for AIP-69 (#40224) for Windows compatability I saw some error beings raised because of problematic import of fnctl in Windows.
This is used (and was introduced by me) to lock exclusive access for virtualenv install. But other code is not affected. Therefore moved the import to the location where needed and... whoops. PoC with Windows was (almost) working.
This PR therefore does not enable Windows support but fixes one of the problems.
related: #10388