-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Google Cloud Generative Model Hooks/Operators to bring parity with Vertex AI API #40484
Update Google Cloud Generative Model Hooks/Operators to bring parity with Vertex AI API #40484
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all, thank you for your contribution!
Overall - it looks promising, as adapting parity with the latest API and naming conventions is important.
However, I'm quite worried that the proposed changes in their current form are too overwhelming, in terms of breaking changes. If someone updates their GCP provider after having these changes in the new version, they will have no clue where operators and hooks are suddenly gone without prior notice.
I suggest making the transition more gradual by keeping all the existing hooks/operators and parameters and adding deprecation warnings where applicable (there are examples within Airflow's source code, even within the GCP provider itself).
Also, I'd like @VladaZakharova to take a look, as her team has been working on Vertex AI operators recently.
@shahar1 Thank you for your feedback. I agree with your points. I'll add a commit that retains the old operators/hooks and include deprecation warnings. |
airflow/providers/google/cloud/hooks/vertex_ai/generative_model.py
Outdated
Show resolved
Hide resolved
conflicts |
And again :( conflicts |
…with Vertex AI API (apache#40484)
With the constantly evolving Vertex AI APIs for generative models, this PR updates the generative_model hooks/operators in the following ways:
for more information visit: https://cloud.google.com/vertex-ai/generative-ai/docs/start/quickstarts/quickstart-multimodal
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.