Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve google vertex ai deprecations in tests #40506

Merged
merged 5 commits into from
Jul 4, 2024
Merged

Resolve google vertex ai deprecations in tests #40506

merged 5 commits into from
Jul 4, 2024

Conversation

dirrao
Copy link
Contributor

@dirrao dirrao commented Jun 30, 2024

Resolve google vertex ai deprecations in tests
related: #38642

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Jun 30, 2024
@dirrao dirrao requested review from Taragolis, Lee-W and shahar1 June 30, 2024 12:54
@dirrao dirrao requested review from Lee-W and shahar1 July 2, 2024 05:56
MaksYermak
MaksYermak reviewed Jul 2, 2024
View reviewed changes
Copy link
Contributor

@MaksYermak MaksYermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dirrao what do you think about removing these properties training_pipeline https://github.com/apache/airflow/blob/main/airflow/providers/google/cloud/operators/vertex_ai/auto_ml.py#L649 and custom_job https://github.com/apache/airflow/blob/main/airflow/providers/google/cloud/operators/vertex_ai/custom_job.py#L1688 from operators if we already decided to resolve deprecations?

@dirrao
Copy link
Contributor Author

dirrao commented Jul 2, 2024

@dirrao what do you think about removing these properties training_pipeline https://github.com/apache/airflow/blob/main/airflow/providers/google/cloud/operators/vertex_ai/auto_ml.py#L649 and custom_job https://github.com/apache/airflow/blob/main/airflow/providers/google/cloud/operators/vertex_ai/custom_job.py#L1688 from operators if we already decided to resolve deprecations?

vertex_ai custom job tests requires rewrite of unit test cases and will be addressed in a separate MR.

@potiuk
Copy link
Member

potiuk commented Jul 2, 2024

there are some conflict markers left

@dirrao
Copy link
Contributor Author

dirrao commented Jul 3, 2024

there are some conflict markers left

Done.

@Lee-W
Copy link
Member

Lee-W commented Jul 3, 2024

We might still need to fix the CI failure

@potiuk potiuk merged commit 3c1120a into apache:main Jul 4, 2024
51 checks passed
@eladkal eladkal mentioned this pull request Jul 9, 2024
Closed
52 tasks
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
@dirrao @romsharon98
Resolve google vertex ai deprecations in tests (apache#40506)
2a89ffb 
* Resolve google vertex ai deprecations in tests

* Resolve google vertex ai deprecations in tests

* Update deprecations_ignore.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaksYermak MaksYermak MaksYermak left review comments

@Lee-W Lee-W Lee-W approved these changes

@potiuk potiuk potiuk approved these changes

@Taragolis Taragolis Awaiting requested review from Taragolis

@shahar1 shahar1 Awaiting requested review from shahar1

Assignees
No one assigned
Labels
area:providers provider:google Google (including GCP) related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dirrao @potiuk @Lee-W @MaksYermak @shahar1