Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 to wasb #40511

Merged
merged 20 commits into from
Jul 8, 2024
Merged

S3 to wasb #40511

merged 20 commits into from
Jul 8, 2024

Conversation

jroachgolf84
Copy link
Contributor

@jroachgolf84 jroachgolf84 commented Jul 1, 2024

This pull request looks to add an operator to the Microsoft provider to move data from S3 to Azure Blob Storage (WASB). The operator has full test-coverage, include an example DAG in tests/system/providers/microsoft/azure/example_s3_to_wasb.py.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link

boring-cyborg bot commented Jul 1, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@jroachgolf84 jroachgolf84 force-pushed the s3_to_wasb branch 2 times, most recently from 2aefeef to 2b33cec Compare July 1, 2024 18:50
@jroachgolf84
Copy link
Contributor Author

Pull request is ready to be reviewed.

@potiuk
Copy link
Member

potiuk commented Jul 7, 2024

RawIOBase has no public constructor and it started to fail in Python 3.12 compatibility tests - that's why the tests are failing for you - you should write bytes to RawIOBase() rather than pass them as constructor arguments.

@jroachgolf84
Copy link
Contributor Author

RawIOBase has no public constructor and it started to fail in Python 3.12 compatibility tests - that's why the tests are failing for you - you should write bytes to RawIOBase() rather than pass them as constructor arguments.

Thank you, I've updated the unit tests just now!

@potiuk potiuk merged commit 03b1840 into apache:main Jul 8, 2024
105 checks passed
Copy link

boring-cyborg bot commented Jul 8, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024

---------

Co-authored-by: Jake Roach <jroachgolf84@jroachgolf84-macbook-m3pro.local>
Co-authored-by: Jake Roach <jroachgolf84@jroachgookm3pro.mynetworksettings.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants