fix OpenLineage extraction for GCP deferrable operators #40521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:google
kacpermuda
force-pushed
the
fix-ol-gcp-deferrable
branch
from
7c86a02
to
76acff0
Compare
Signed-off-by: Kacper Muda <mudakacper@gmail.com>
kacpermuda
force-pushed
the
fix-ol-gcp-deferrable
branch
from
76acff0
to
c523cba
Compare
potiuk
approved these changes
Jul 1, 2024
52 tasks
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
Signed-off-by: Kacper Muda <mudakacper@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After being deferred in case of some operators, OpenLineage methods do not have access to job_id so we need to reassign it in
execute_complete()and also adjust OL methods to create any other attributes that might be missing after deferral. Similar to #40457Also removing unnecessary private
self._job_idfrom BigQueryToGCSOperator, i created it some time ago but it duplicates publicself.job_idand it's used only by OpenLineage, so we safely can remove it.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.