Revert "Fix GCSToGCSOperator behavior difference for moving single object (#40162)"
#40577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:google
|
@eladkal FYI |
moiseenkov
approved these changes
Jul 3, 2024
…object (apache#40162)" This reverts commit 2f2796f.
MaksYermak
force-pushed
the
revert-changes
branch
from
c586275 to
44937c3
Compare
|
Should we add special release notes? (the original PR had) |
|
For more context, examples in the documentation and some system tests where the destination file is specified fully are broken before this revert. |
potiuk
approved these changes
Jul 3, 2024
Yeah. I added this PR #40579 and we shall discuss the note there (and agree on the version) |
52 tasks
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
…object (apache#40162)" (apache#40577) This reverts commit 2f2796f.
project-defiant
pushed a commit
to opentargets/orchestration
that referenced
this pull request
Aug 27, 2024
github-merge-queue bot
pushed a commit
to opentargets/orchestration
that referenced
this pull request
Sep 2, 2024
* feat: dynamic dag extracted * feat: finngen finemapping ingestion dag * refactor: gwas_catalog processing dag * chore: updated poetry.lock * refactor: simplified structure * chore: drop commented line * refactor: update of apache-airflow-providers-google to stable version - see apache/airflow#40577 * fix: remove stray line * fix: remove stray line * chore: yaml formatter in pre-commit * chore: format yaml files * chore: added comments explaining pre-commit hook usage * chore: drop docstyles * chore: interrogate setup * chore: interrogate setup * chore: pydoclint and pydocstyle setup * chore: ruff format docstrings * fix: move config to the package * fix: refactor manifest status collection * chore: fixed typo * feat: extracted gcshook as a cached property * feat: unify camel case for type definitions * feat: implicit batch resource creation * feat: unify gcs pattern * refactor: use base operator logger * refactor: addressed comments * fix: dynamic dag fixes * refactor(IOManager): reduced number of n_threads * refactor: rollback pis config blank lines * fix: delete duplicated config * fix: lazy storage.Client execution * chore: update poetry lock * chore: bump poetry version in pre-commit * chore: force update poetry cache --------- Co-authored-by: Szymon Szyszkowski <ss60@mib117351s.internal.sanger.ac.uk>
project-defiant
added a commit
to opentargets/orchestration
that referenced
this pull request
Sep 2, 2024
* feat: dynamic dag extracted * feat: finngen finemapping ingestion dag * refactor: gwas_catalog processing dag * chore: updated poetry.lock * refactor: simplified structure * chore: drop commented line * refactor: update of apache-airflow-providers-google to stable version - see apache/airflow#40577 * fix: remove stray line * fix: remove stray line * chore: yaml formatter in pre-commit * chore: format yaml files * chore: added comments explaining pre-commit hook usage * chore: drop docstyles * chore: interrogate setup * chore: interrogate setup * chore: pydoclint and pydocstyle setup * chore: ruff format docstrings * fix: move config to the package * fix: refactor manifest status collection * chore: fixed typo * feat: extracted gcshook as a cached property * feat: unify camel case for type definitions * feat: implicit batch resource creation * feat: unify gcs pattern * refactor: use base operator logger * refactor: addressed comments * fix: dynamic dag fixes * refactor(IOManager): reduced number of n_threads * refactor: rollback pis config blank lines * fix: delete duplicated config * fix: lazy storage.Client execution * chore: update poetry lock * chore: bump poetry version in pre-commit * chore: force update poetry cache --------- Co-authored-by: Szymon Szyszkowski <ss60@mib117351s.internal.sanger.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 2f2796f.
These changes broke the
GCSToGCSoperator and, also, operators which rely on this operator. The most use case after these changes do not work.For example in one of our system tests for video intelligence operator we have this operation for GCSToGCS:
and now the result of this operation is
B2/video.mp/cat.mp4, but the expected result should beB2/video.mp4.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.