Do not dynamically determine op links for emr serverless start job operator #40627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dynamic determination of which extra link to include for the EmrServerlessStartJobOperator does not work with templated fields, since that evaluation was happening at DAG parsing time. This dynamic determination has been completely removed because: 1) If using templated fields for some inputs it needed, DAG parsing would fail. 2) Changing the DAG definition relating to those links, would often remove links for all previous DAG runs. 3) It overly complicates the code. The new behaviour is to add all links to the TI and only those that are enabled will be "persisted" (i.e. actually have a link) and those that are not will be present but greyed out and will link back to the TI (the Airflow default).
boring-cyborg
bot
added
area:providers
kind:documentation
provider:amazon-aws
2 tasks
|
CC @dacort |
|
Big fan of removing the complicated code, never really liked it. The main reason I did the dynamic stuff is because the list of buttons got really long at one point, but it doesn't look as bad as I remember in the screenshot. 😁 I did take a quick peak to make sure it will still function as intended and looks like the operator itself has duplicate logic to toggle/persist the links, so it should work fine! |
potiuk
approved these changes
Jul 6, 2024
eladkal
approved these changes
Jul 6, 2024
This was referenced Jul 9, 2024
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
The dynamic determination of which extra link to include for the EmrServerlessStartJobOperator does not work with templated fields, since that evaluation was happening at DAG parsing time. This dynamic determination has been completely removed because: 1) If using templated fields for some inputs it needed, DAG parsing would fail. 2) Changing the DAG definition relating to those links, would often remove links for all previous DAG runs. 3) It overly complicates the code. The new behaviour is to add all links to the TI and only those that are enabled will be "persisted" (i.e. actually have a link) and those that are not will be present but greyed out and will link back to the TI (the Airflow default).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dynamic determination of which extra link to include for the EmrServerlessStartJobOperator does not work with templated fields, since that evaluation was happening at DAG parsing time. This dynamic determination has been completely removed because:
would fail.
remove links for all previous DAG runs.
The new behaviour is to add all links to the TI and only those that are enabled will be "persisted" (i.e. actually have a link) and those that are not will be present but greyed out and will link back to the TI (the Airflow default).
fixes #40103
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.