-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance User Experience by Opening external UI Links in new Tab on browser. #40635
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
Still Finalizing tests on this. |
May need to modify the test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked closer - small thing requested - to be more precise with URL prefix check rather than apache
in the name,
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
DESCRIPTION
In the Airflow UI today, a couple of pages on the Menu bar have links that point to external Apache Airflow related links eg; documentation/github Repo as outlined here .
Issue:
At the moment, when a user clicks on them, it literally removes you from the UI on the same browser tab. Users now need to click back to return to the UI, it gets more tricky when you've clicked so many links on the docs page. This is same for the prompt that comes up when no webserverSecretKey has been set.
Included: Also open provider links in new tab.
Proposed Solution:
Simply enrich the html tags to open in a new tab, easier to modify this via jinja.
Concerns: As at today, we have very few external links directly in the Menu Bar. Coincidentally containing "apache", if this changes in future, then users would experience the same issue.
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.