Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make XCom display as react json #40640

Merged

Conversation

jscheffl
Copy link
Contributor

@jscheffl jscheffl commented Jul 7, 2024

Same like #40639 this PR attempts to make the grid XCom display being a proper JSON react view.

Note: This PR just adds one commit on top of PR #40639: c8601cf

image

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Jul 7, 2024
@jscheffl jscheffl force-pushed the feature/make-xcom-display-as-react-json branch from a85ca8b to c8601cf Compare July 8, 2024 21:25
@jscheffl jscheffl marked this pull request as ready for review July 8, 2024 21:26
@jscheffl jscheffl added this to the Airflow 2.10.0 milestone Jul 8, 2024
@jscheffl
Copy link
Contributor Author

jscheffl commented Jul 8, 2024

@bbovenzi made the changes of review feedback in #40639 - will rebase the second PR once the first is OK :-D

@jscheffl jscheffl force-pushed the feature/make-xcom-display-as-react-json branch from c8601cf to 00aa301 Compare July 9, 2024 17:40
@jscheffl jscheffl requested a review from bbovenzi July 9, 2024 17:41
@jscheffl jscheffl force-pushed the feature/make-xcom-display-as-react-json branch from 00aa301 to bdf0725 Compare July 12, 2024 20:06
@jscheffl jscheffl requested a review from bbovenzi July 12, 2024 20:08
@jscheffl jscheffl force-pushed the feature/make-xcom-display-as-react-json branch from bdf0725 to 191644f Compare July 16, 2024 21:49
@jscheffl jscheffl added the area:API Airflow's REST/HTTP API label Jul 16, 2024
@jscheffl jscheffl force-pushed the feature/make-xcom-display-as-react-json branch from 191644f to 055200b Compare July 17, 2024 16:58
@jscheffl jscheffl force-pushed the feature/make-xcom-display-as-react-json branch from 3524895 to 5f5039a Compare July 17, 2024 18:29
@jscheffl jscheffl merged commit 6c591e5 into apache:main Jul 22, 2024
52 checks passed
@ephraimbuddy ephraimbuddy added the type:improvement Changelog: Improvements label Jul 22, 2024
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
* Enable proper JSON view in Xcom display as well

* Review feedback

* Implement a native endpoint for XCom API to prevent retrieval as Python JSON string

* Fix pytests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:improvement Changelog: Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants