Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataprocCreateBatchOperator - Link for asynchronous mode #40643

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

kandharvishnu
Copy link
Contributor

@kandharvishnu kandharvishnu commented Jul 8, 2024

This PR adds DataprocBatchLink.persist to display the link for DataprocCreateBatchOperator.

When asynchronous is set to True and deferrable is set to False, attempting to access the Dataproc Batch Extra Links button results in a broken link:
image

To resolve this, we push the value to XCom using the persist function when asynchronous is enabled. This ensures that when the user tries to access the Dataproc Batch Extra Links button, the value is correctly fetched from XCom:
image

Adding DataprocBatchLink.persist to display link for createbatch operator
@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Jul 8, 2024
Copy link
Contributor

@moiseenkov moiseenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, could you please clarify how this change works for deferrable mode? As far as I can see, the added code can be reached only when deferrable=False and asynchronous=True. Perhaps, the PR title and description might be updated?

@kandharvishnu
Copy link
Contributor Author

kandharvishnu commented Jul 8, 2024

Hi, could you please clarify how this change works for deferrable mode? As far as I can see, the added code can be reached only when deferrable=False and asynchronous=True. Perhaps, the PR title and description might be updated?

Sorry my bad, yes it is deferrable=False and asynchronous=True and I will update both PR title and description

@kandharvishnu kandharvishnu changed the title DataprocCreateBatchOperator - Link for deferrable mode DataprocCreateBatchOperator - Link for asynchronous mode Jul 8, 2024
@potiuk potiuk merged commit f12714d into apache:main Jul 8, 2024
51 checks passed
Copy link

boring-cyborg bot commented Jul 8, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@kandharvishnu kandharvishnu deleted the patch-1 branch July 9, 2024 05:19
@kandharvishnu kandharvishnu restored the patch-1 branch July 9, 2024 05:19
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
Adding DataprocBatchLink.persist to display link for createbatch operator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants